ci(release): drop macos-x64 from release matrix#200
Open
Sun-sunshine06 wants to merge 1 commit intomainfrom
Open
ci(release): drop macos-x64 from release matrix#200Sun-sunshine06 wants to merge 1 commit intomainfrom
Sun-sunshine06 wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Sun-sunshine06 <Sun-sunshine06@users.noreply.github.com>
github-actions
Bot
added
area:packaging
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Findings
- [Major] Removing
macos-x64drops a documented supported release artifact — the new build matrix now publishes only the Apple Silicon DMG, so the next GitHub Release will have no installer for Intel Macs. That is a user-visible support regression, not just a CI optimization: the repo still documentsopen-codesign-*-x64.dmgas the Intel macOS installer inREADME.md:151,README.zh-CN.md:149, andwebsite/quickstart.md:33, andwebsite/faq.md:86still lists Intel macOS as supported.CHANGELOG.md:48also records the earlier fix to ship a correct x64 DMG. Evidence in this PR:.github/workflows/release.yml:129.
Suggested fix:# Keep Intel packaging non-blocking instead of removing it from releases. build-macos-x64: name: Build (macos-x64, best-effort) needs: [gate, changelog] runs-on: macos-13 continue-on-error: true steps: # same checkout / setup / install / build steps as the main build job - run: pnpm --filter @open-codesign/desktop exec electron-vite build - run: pnpm --filter @open-codesign/desktop exec electron-builder --mac --x64 --publish never
Summary
Review mode: initial
One major regression found: this PR stops shipping the Intel macOS installer while the project still advertises Intel support. If Intel support is being intentionally dropped, that contract change needs to be made explicit in the docs/site/release messaging in the same PR instead of silently disappearing from the release matrix.
Testing
Not run (automation)
open-codesign Bot
| # Actions capacity, which blocks the whole release pipeline because | ||
| # `publish` waits for the full `build` matrix to finish. | ||
| include: | ||
| - os: macos-latest # arm64 Apple Silicon runner |
Contributor
There was a problem hiding this comment.
[Major] This matrix now removes the only macos-x64 release artifact. The repo still advertises Intel macOS support in README.md:151, README.zh-CN.md:149, website/quickstart.md:33, and website/faq.md:86, so this is a release-support regression rather than just a CI optimization.
Suggested fix:
build-macos-x64:
name: Build (macos-x64, best-effort)
needs: [gate, changelog]
runs-on: macos-13
continue-on-error: true
steps:
- run: pnpm --filter @open-codesign/desktop exec electron-vite build
- run: pnpm --filter @open-codesign/desktop exec electron-builder --mac --x64 --publish never
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily remove
macos-x64from the release matrix.Why
The Intel macOS runner queue is chronically unavailable for this repo right now, which blocks the whole release pipeline because
publishwaits for the fullbuildmatrix to finish.Notes
macos-arm64,windows,ubuntu, andsnapremain unchanged.v0.1.4release so the current packaging run can finish without waiting onmacos-x64.